0001123: With Xdebug 2.3.1, PHPUnit with coverage is exponentially slower than without

(0003052)
Arjen (reporter)
2015-03-23 12:57

I can confirm this.

2.2.7 with coverage: 3 min 45 sec
2.3.2 with coverage: 20 min
2.3.2 without coverage: 1 min 35 sec

(0003073)
gcth (reporter)
2015-04-27 11:59

Same for me, for jenkins jobs, with phpunit 4.6 and php -v:

PHP 5.6.8-1~dotdeb+wheezy.1 (cli) (built: Apr 22 2015 04:03:53)
Copyright (c) 1997-2015 The PHP Group
Zend Engine v2.6.0, Copyright (c) 1998-2015 Zend Technologies
with Xdebug v2.3.2, Copyright (c) 2002-2015, by Derick Rethans
with Zend OPcache v7.0.4-dev, Copyright (c) 1999-2015, by Zend Technologies

I've attached build time trend with coverage enabled.

(0003089)
sebastian (reporter)
2015-05-27 12:46

It is to be expected for the execution to be slower when XDEBUG_CC_BRANCH_CHECK is enabled. But without it the performance of the code coverage data collection with Xdebug 2.2 and 2.3 should be the same.

(0003090)
Arjen (reporter)
2015-05-27 12:52

Just to be clear: this slowdown is with XDEBUG_CC_BRANCH_CHECK disabled (not enabled).

(0003108)
mindplay (reporter)
2015-06-04 10:09

I can confirm the performance problem with 2.3.2, which came with the WPN-XM stack - downgrading to 2.2.7 is my temporary work-around too, it performs normally.

(0003109)
sebastian (reporter)
2015-06-04 10:43

I attached two valgrind/callgrind profiles generated with PHP 5.6.9 and both Xdebug 2.2.7 and 2.3.2.

$ git clone https://github.com/sebastianbergmann/money.git [^]
$ cd money
$ valgrind --tool=callgrind /usr/local/php-5.6.9/bin/php ./build/tools/phpunit.phar -c build

(0003128)
Arjen (reporter)
2015-06-24 14:34

I'm not sure, but I think this line https://github.com/xdebug/xdebug/blob/1eb61105f811d09bc90109c611083ac0fad62dc4/xdebug_code_coverage.c#L108 [^]
should read "if (XG(code_coverage_branch_check)) {"

(0003194)
derick (administrator)
2015-10-25 00:11

Fixed for 2.3.4 (if that gets released) and Xdebug 3.0.0

Issue History
Date Modified	Username	Field	Change
2015-03-04 13:10	ravage	New Issue
2015-03-23 12:57	Arjen	Note Added: 0003052
2015-04-27 11:57	gcth	File Added: xdebug-2.3.2-coverage-time.png
2015-04-27 11:59	gcth	Note Added: 0003073
2015-05-27 12:46	sebastian	Note Added: 0003089
2015-05-27 12:52	Arjen	Note Added: 0003090
2015-06-04 10:09	mindplay	Note Added: 0003108
2015-06-04 10:40	sebastian	File Added: xdebug_227_callgrind.out.12939
2015-06-04 10:40	sebastian	File Added: xdebug_232_callgrind.out.13320
2015-06-04 10:43	sebastian	Note Added: 0003109
2015-06-24 14:34	Arjen	Note Added: 0003128
2015-10-25 00:11	derick	Note Added: 0003194
2015-10-25 00:11	derick	Status	new => closed
2015-10-25 00:11	derick	Assigned To	=> derick
2015-10-25 00:11	derick	Resolution	open => fixed
2015-10-25 00:11	derick	Fixed in Version	=> 2.3.4
2015-11-05 15:08	derick	Fixed in Version	2.3.4 => 2.4.0beta1
2016-07-31 13:36	derick	Category	Usage problems => Usage problems (Crashes)
2016-07-31 13:38	derick	Category	Usage problems (Crashes) => Usage problems (Wrong Results)

Notes
(0003052) Arjen (reporter) 2015-03-23 12:57	I can confirm this. 2.2.7 with coverage: 3 min 45 sec 2.3.2 with coverage: 20 min 2.3.2 without coverage: 1 min 35 sec

(0003073) gcth (reporter) 2015-04-27 11:59	Same for me, for jenkins jobs, with phpunit 4.6 and php -v: PHP 5.6.8-1~dotdeb+wheezy.1 (cli) (built: Apr 22 2015 04:03:53) Copyright (c) 1997-2015 The PHP Group Zend Engine v2.6.0, Copyright (c) 1998-2015 Zend Technologies with Xdebug v2.3.2, Copyright (c) 2002-2015, by Derick Rethans with Zend OPcache v7.0.4-dev, Copyright (c) 1999-2015, by Zend Technologies I've attached build time trend with coverage enabled.

(0003089) sebastian (reporter) 2015-05-27 12:46	It is to be expected for the execution to be slower when XDEBUG_CC_BRANCH_CHECK is enabled. But without it the performance of the code coverage data collection with Xdebug 2.2 and 2.3 should be the same.

(0003090) Arjen (reporter) 2015-05-27 12:52	Just to be clear: this slowdown is with XDEBUG_CC_BRANCH_CHECK disabled (not enabled).

(0003108) mindplay (reporter) 2015-06-04 10:09	I can confirm the performance problem with 2.3.2, which came with the WPN-XM stack - downgrading to 2.2.7 is my temporary work-around too, it performs normally.

(0003109) sebastian (reporter) 2015-06-04 10:43	I attached two valgrind/callgrind profiles generated with PHP 5.6.9 and both Xdebug 2.2.7 and 2.3.2. $ git clone https://github.com/sebastianbergmann/money.git [^] $ cd money $ valgrind --tool=callgrind /usr/local/php-5.6.9/bin/php ./build/tools/phpunit.phar -c build

(0003128) Arjen (reporter) 2015-06-24 14:34	I'm not sure, but I think this line https://github.com/xdebug/xdebug/blob/1eb61105f811d09bc90109c611083ac0fad62dc4/xdebug_code_coverage.c#L108 [^] should read "if (XG(code_coverage_branch_check)) {"

(0003194) derick (administrator) 2015-10-25 00:11	Fixed for 2.3.4 (if that gets released) and Xdebug 3.0.0

Relationships