View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0001775 | Xdebug | Step Debugging | public | 2020-04-06 14:32 | 2020-04-17 19:06 |
Reporter | pluczkiewicz | Assigned To | derick | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 2.9.4 | ||||
Fixed in Version | 2.9.5 | ||||
Summary | 0001775: Segfault when another extension compiles a PHP file during RINIT | ||||
Description | Xdebug 2.9.1 and newer segfaults with ddtrace.
| ||||
Steps To Reproduce |
| ||||
Tags | No tags attached. | ||||
Operating System | |||||
PHP Version | 7.4.0-7.4.4 | ||||
|
How can I do this without Docker? Your docker container/setup likely has no debugging set-up whatsover... |
|
You can do this by installing php-fpm (I tested on 7.4.3 and 7.4.4), the ddtrace extension (I used 0.42.0, install instructions: https://docs.datadoghq.com/tracing/setup/php/, github repo: https://github.com/DataDog/dd-trace-php) and xdebug. ddtrace setings xdebug settings: |
|
Did you actually check this with Xdebug 2.9.4? Because this is the same issue as 0001736, which was fixed by the authors of the ddtrace extension with the exact log message:
The fix for that is part of Xdebug 2.9.2. |
|
Yes. It's still failing on 2.9.2, 2.9.3 and 2.9.4. The interesting detail is that it's segfaulting on all of the requests on 2.9.1, but only on around half of them on 2.9.2 and later. |
|
I think the issue is that breakable_lines_map isn't initialized here: https://github.com/xdebug/xdebug/blob/2afa19428cada525b5cc2f01752f1036c358adef/src/debugger/debugger.c#L51 so there's no guarantee that the pointer will be NULL before the hashmap is allocated |
|
I think it's just missing a <pre> below: But I want to reproduce it first :-) |
|
This is now fixed in GIT. I could reproduce this with "php -S" and two requests. |
|
That's wonderful news. Thank you! |
|
Thanks Derick! I can confirm that this commit fixes the issue on my end as well. <3 https://github.com/xdebug/xdebug/commit/6c6c08233593ffc1d64d70c51c56f567e6528010 |
Date Modified | Username | Field | Change |
---|---|---|---|
2020-04-06 14:32 | pluczkiewicz | New Issue | |
2020-04-06 14:34 | derick | Assigned To | => derick |
2020-04-06 14:34 | derick | Status | new => feedback |
2020-04-06 14:34 | derick | Note Added: 0005377 | |
2020-04-06 14:41 | pluczkiewicz | Note Added: 0005378 | |
2020-04-06 14:41 | pluczkiewicz | Status | feedback => assigned |
2020-04-12 15:34 | derick | Status | assigned => feedback |
2020-04-12 15:34 | derick | Note Added: 0005382 | |
2020-04-14 08:07 | pluczkiewicz | Note Added: 0005385 | |
2020-04-14 08:07 | pluczkiewicz | Status | feedback => assigned |
2020-04-14 15:10 | pluczkiewicz | Note Added: 0005388 | |
2020-04-14 16:37 | derick | Note Added: 0005389 | |
2020-04-14 16:37 | derick | Note Edited: 0005389 | |
2020-04-16 10:46 | derick | Status | assigned => closed |
2020-04-16 10:46 | derick | Resolution | open => fixed |
2020-04-16 10:46 | derick | Fixed in Version | => 2.9.5 |
2020-04-16 10:46 | derick | Note Added: 0005390 | |
2020-04-16 10:49 | pluczkiewicz | Note Added: 0005391 | |
2020-04-17 19:06 | SammyK | Note Added: 0005397 |