View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0002045 | Xdebug | Uncategorized | public | 2021-11-19 12:34 | 2022-12-08 18:50 |
Reporter | Danack | Assigned To | derick | ||
Priority | low | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 3.2dev | ||||
Fixed in Version | 3.2.0 | ||||
Summary | 0002045: Inapproriate frowny face | ||||
Description | I realise this is a trivial thing, but one of the error messages has a smiley face, which annoys me, as I don't like my computer to try to manipulate my emotions. " Xdebug: [Step Debug] Time-out connecting to debugging client, waited: 200 ms. Tried: 10.254.254.254:9000 (through xdebug.client_host/xdebug.client_port) :-(" The frowny face is also inappropriate - although I have xdebug configured to attempt to connect to a debugger, its deliberate that I don't have PHPStorm listening for connections, as I just switch it to listening when I'm actually debugging something. Instead of the frowny face, it would be better to have something like a url for a page for how to debug this, and words to the effect "if you were hoping for xdebug to connect, checklist is here". | ||||
Steps To Reproduce | zend_extension=xdebug.so | ||||
Tags | No tags attached. | ||||
Operating System | |||||
PHP Version | 8.0.10-8.0.19 | ||||
|
I'd happy to receive a PR to remove the faces. The code is at https://github.com/xdebug/xdebug/blob/master/src/debugger/com.c#L497-L516 — Please follow the contribution guidelines at https://github.com/xdebug/xdebug/blob/master/CONTRIBUTING.rst If you view the log through Xdebug's diagnostics log (by using xdebug_info(), you will see that each message has a link to a specific issue on the documentation of errors at https://xdebug.org/docs/errors — I don't really want to put an URL in the log for every message that Xdebug puts out. I think that would be enough? |
|
I gave this a go in https://github.com/xdebug/xdebug/pull/810 |
|
Thanks for the patch! |
Date Modified | Username | Field | Change |
---|---|---|---|
2021-11-19 12:34 | Danack | New Issue | |
2021-11-19 13:22 | derick | Assigned To | => derick |
2021-11-19 13:22 | derick | Status | new => feedback |
2021-11-19 13:22 | derick | Note Added: 0006158 | |
2021-11-30 17:10 | kaznovac | Note Added: 0006164 | |
2021-12-02 16:23 | derick | Product Version | 3.1.1 => 3.2dev |
2021-12-08 14:22 | derick | Status | feedback => closed |
2021-12-08 14:22 | derick | Resolution | open => fixed |
2021-12-08 14:22 | derick | Fixed in Version | => 3.2dev |
2021-12-08 14:22 | derick | Note Added: 0006172 | |
2022-07-20 15:49 | derick | Fixed in Version | 3.2dev => 3.2.0alpha1 |
2022-12-08 18:50 | derick | Fixed in Version | 3.2.0alpha1 => 3.2.0 |