View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001973 | Xdebug | Uncategorized | public | 2021-05-13 01:38 | 2023-08-01 10:33 |
| Reporter | maaarghk | Assigned To | derick | ||
| Priority | low | Severity | tweak | Reproducibility | always |
| Status | feedback | Resolution | open | ||
| Product Version | 3.0.4 | ||||
| Summary | 0001973: var_dump on an extension object could use get_class_name object handler | ||||
| Description | I am looking here specifically: when I have xdebug loaded, if I var_dump($object) where $object is a class defined by a custom extension, the base name of that class will be output. However, the extension can define an object handler function get_class_name which adds additional information here, e.g.: https://github.com/php/php-src/blob/01b3fc03c30c6cb85038250bb5640be3a09c6a32/ext/ffi/ffi.c#L1636 Would you accept a pull request on this? | ||||
| Tags | No tags attached. | ||||
| Operating System | |||||
| PHP Version | 8.0.0-8.0.4 | ||||
|
|
Hi, I did not know that existed :-) I would indeed welcome a pull request, as long as it's also done for var_export_line, and var_export_text. Please follow the guidelines at https://xdebug.org/docs/contributing As this is a new feature, it should be against the master branch. If you're unsure about anything, or have questions, please reach out. cheers, |
|
|
Are you still considering making a PR for this? |
|
|
Hi, yes, I got some way towards this actually but got stuck on an issue and forgot to follow it up. The question is regarding tests. The FFI extension is the only upstream extension which uses this functionality, so I would require it to write a test. Does your CI system have it installed? More generally do you consider that a correct approach? Or do you have anything like test extensions / features which are built only for the purposes of testing xdebug itself, but not built for release? |
|
|
Sorry, I dropped the ball on this. Do you have an example of code where this would make an impact? Such as some code that uses FFI? I'm having a hard time trying to figure out how this works on the FFI side of things. cheers, |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2021-05-13 01:38 | maaarghk | New Issue | |
| 2021-05-19 12:02 | derick | Assigned To | => derick |
| 2021-05-19 12:02 | derick | Status | new => feedback |
| 2021-05-19 12:02 | derick | Note Added: 0005879 | |
| 2021-08-07 10:06 | derick | Note Added: 0005965 | |
| 2021-08-09 09:17 | maaarghk | Note Added: 0005971 | |
| 2021-08-09 09:17 | maaarghk | Status | feedback => assigned |
| 2023-08-01 10:33 | derick | Status | assigned => feedback |
| 2023-08-01 10:33 | derick | Note Added: 0006624 |
