Hi,

This is odd. I had a look at the code difference between 3.3.0alpha2 and 3.3.0, to see if there could have been a change here, but I can't find a possible commit that could have caused this.

Would you be able to run your test again, but this time with xdebug.log_level=11 configured as well? That adds a load more information that could provide an insight.

cheers,
Derick

Hi Derick,

Thanks for picking this up and taking a look for me. Due to the size of one of the files, I’ve uploaded both versions to a shared OneDrive folder:

https://ompensions-my.sharepoint.com/:f:/g/personal/danny_guest_fincalc_co_uk/EhCa6b3yNbVBrVnx4WrYRdEBXHk-gct--bJJ-aKiVAJYLA?e=YjKlLr

I’ve tested the same scenario using version 3.3.0, where the breakpoint does not trigger, and 3.3.0 Alpha 2, where it does work as expected.

Really appreciate your help looking into this.

Best regards,
Danny

I don’t have full context, but the only change that seems like it could have caused this is in version 3.3.0Alpha3, where it mentions: 'Fixed bug 0002206: Optimize debugger breakpoints checking.' That might be related?"

You're absolutely right. After readying through the patch for that again, I found (https://github.com/xdebug/xdebug/commit/68342a73330c1c3ce13e054a1964fc56fb94c9e7#diff-d4b049f95775849818cf2c0c6dbcaf0569810a7e7030cdd237073634abcb497eL2737):

-   if (strncasecmp(ZSTR_VAL(brk->filename), tmp_file, ZSTR_LEN(brk->filename)) == 0) {
+   if (zend_string_equals(brk->filename, resolved_filename)) {

The old one uses case-sensitive comparison (strncasecmp) and the new version uses an equality check (zend_string_equals).

Now let's see if I can create a reproducible case (should be easy), and then fix it.

https://github.com/xdebug/xdebug/pull/1018

Derick that is great news and thank you for investigating and fixing the issue. When can we expect it to make it's way into a full release?

I'm hoping to fix 0002332 and 0002339 today, and then in the next few days make a release.