View Issue Details

IDProjectCategoryView StatusLast Update
0001189XdebugUncategorizedpublic2015-12-07 11:32
Reportertechkey Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
PlatformWindows x64OSMicrosoft Windows 10 ProOS Version10.0.10240 Build
Target Version2.4.1Fixed in Version2.4.0rc2 
Summary0001189: Remove address attribute from remote debugging responses, as they sometimes get negative and expose potential security issues
Description

Tests (e.g. bug00421.phpt) that check XML returns negative addresses in the address attribute.

Steps To Reproduce

Run tests that check XML and look at the addresses.

Additional Information

Has this to do with lines like:

xdebug_xml_add_attribute_ex(node, "address", xdebug_sprintf("%ld", (long) val), 0, 1);

in xdebug_var.c? Note the 'd' (signed integer) in "%ld".

Negative address values are not filtered out in line 49 of dbgpclient.php (addresses shouldn't be negative in the first place).

This happens in PHP5.6.13 with xdebug 2.3.3.1 (downloaded dll and built from source) and PHP7 with xdebug master (built from source).

TagsNo tags attached.
Operating SystemMicrosoft Windows 10 Pro 10.0.10240 Build 10240 x64
PHP Version5.1.0

Activities

derick

2015-12-02 23:03

administrator   ~0003281

Fixed for 2.4.0 (by removing the whole address nonsense in the first place).