0001541: switch/case case is not covered when using php-fpm php 7.0

ID	Project	Category	View Status	Date Submitted	Last Update
0001541	Xdebug	Code Coverage	public	2018-03-26 14:42	2019-08-26 12:37

Reporter	theoboldt	Assigned To
Priority	normal	Severity	major	Reproducibility	always
Status	closed	Resolution	duplicate
Platform	Linux	OS	Ubuntu	OS Version	16.04.1
Product Version	2.6.0
Target Version	2.8.0dev	Fixed in Version	2.8.0beta2

Summary	0001541: switch/case case is not covered when using php-fpm php 7.0
Description	When executing switch/case within a function, no case line of executed cases is marked as covered, except the following: The first line is marked as covered as expected The "default" case is marked as covered as expected The lines are marked as covered as expected when the same file is executed via CLI using same php/xdebug version. {code} <?php function a($option) { switch ($option) { case 'first': $option .= '_covered'; break; case 'second': $option .= '_covered'; break; case 'third': $option .= '_covered'; break; default: $option .= '_covered'; break; } return $option; } xdebug_start_code_coverage(XDEBUG_CC_UNUSED \| XDEBUG_CC_DEAD_CODE); a('first'); a('second'); a('third'); a('default'); $coverage = xdebug_get_code_coverage(); xdebug_stop_code_coverage(); //EVALUATE (not part of proof) print_r( [ 'phpversion(\'xdebug\')' => phpversion('xdebug'), 'phpversion()' => phpversion(), 'php_sapi_name()' => php_sapi_name() ] ); print_r($coverage); ?> {code} When executing above code via CLI, following output is generated: {code} Array ( [phpversion('xdebug')] => 2.6.0 [phpversion()] => 7.0.28-0ubuntu0.16.04.1 [php_sapi_name()] => cli ) Array ( [/intproj/users/erik/xdebug_coverage_issues/switch_case.php] => Array ( [5] => 1 [6] => 1 [7] => 1 [8] => 1 [9] => 1 [10] => 1 [11] => 1 [12] => 1 [13] => 1 [15] => 1 [16] => 1 [18] => 1 [23] => 1 [24] => 1 [25] => 1 [26] => 1 [28] => 1 ) ) {code} When executing above code via Apache 2 (Server API: FPM/FastCGI, PHP API: 20151012, PHP Extension: 20151012) the output differs significantly for line 8 and 11: {code} Array ( [phpversion('xdebug')] => 2.6.0 [phpversion()] => 7.0.28-0ubuntu0.16.04.1 [php_sapi_name()] => fpm-fcgi ) Array ( [/intproj/users/erik/xdebug_coverage_issues/switch_case.php] => Array ( [5] => 1 [6] => 1 [7] => 1 [8] => -1 [9] => 1 [10] => 1 [11] => -1 [12] => 1 [13] => 1 [15] => 1 [16] => 1 [18] => 1 [23] => 1 [24] => 1 [25] => 1 [26] => 1 [28] => 1 ) ) {code}
Steps To Reproduce	Execute provided using php 7.0.28 snipped via php-fpm and via cli as well, compare results
Tags	PHP7, php7.2

Operating System
PHP Version	7.0.25-7.0.29

theoboldt 2018-11-15 10:54 reporter ~0004724	Still reproducible using xdebug 2.6.1.

derick 2018-12-06 12:11 administrator ~0004749	Do you have opcache installed and enabled for the PHP-FPM install?

theoboldt 2018-12-06 15:21 reporter ~0004750	Do you have opcache installed and enabled for the PHP-FPM install? In the provided examples, opcache was installed and enabled. I performed some tests now using PHP 7.0.32-0ubuntu0.16.04.1. It's worth to notice that the results slightly differ when having opcache enabled/disabled, but issue in general still exists: Result having opcache enabled: {code} Array ( [phpversion('xdebug')] => 2.6.0 [phpversion()] => 7.0.32-0ubuntu0.16.04.1 [php_sapi_name()] => fpm-fcgi ) Array ( [/intproj/users/erik/switch_case.php] => Array ( [5] => 1 [6] => 1 [7] => 1 [8] => -1 [9] => 1 [10] => 1 [11] => -1 [12] => 1 [13] => 1 [15] => 1 [16] => 1 [18] => 1 [23] => 1 [24] => 1 [25] => 1 [26] => 1 [28] => 1 ) ) {code} Result having opcache disabled: {code} Array ( [phpversion('xdebug')] => 2.6.0 [phpversion()] => 7.0.32-0ubuntu0.16.04.1 [php_sapi_name()] => fpm-fcgi ) Array ( [/intproj/users/erik/switch_case.php] => Array ( [5] => 1 [6] => 1 [7] => 1 [8] => -1 [9] => 1 [10] => 1 [11] => -1 [12] => 1 [13] => 1 [15] => 1 [16] => 1 [18] => 1 [19] => -2 [23] => 1 [24] => 1 [25] => 1 [26] => 1 [28] => 1 ) ) {code}

theoboldt 2018-12-06 15:33 reporter ~0004753	Also reproducible using php 7.2: opcache enabled: {code} Array ( [phpversion('xdebug')] => 2.6.0 [phpversion()] => 7.2.10-0ubuntu0.18.04.1 [php_sapi_name()] => fpm-fcgi ) Array ( [/intproj/users/erik/switch_case.php] => Array ( [4] => 1 [5] => -1 [6] => 1 [7] => 1 [8] => -1 [9] => 1 [10] => 1 [11] => -1 [12] => 1 [13] => 1 [15] => 1 [16] => 1 [18] => 1 [23] => 1 [24] => 1 [25] => 1 [26] => 1 [28] => 1 ) ) {code} opcache disabled: {code} Array ( [phpversion('xdebug')] => 2.6.0 [phpversion()] => 7.2.10-0ubuntu0.18.04.1 [php_sapi_name()] => fpm-fcgi ) Array ( [/intproj/users/erik/switch_case.php] => Array ( [4] => 1 [5] => -1 [6] => 1 [7] => 1 [8] => -1 [9] => 1 [10] => 1 [11] => -1 [12] => 1 [13] => 1 [15] => 1 [16] => 1 [18] => 1 [19] => -2 [23] => 1 [24] => 1 [25] => 1 [26] => 1 [28] => 1 ) ) {code}

derick 2019-01-22 22:27 administrator ~0004834	I will have a look at this after Xdebug 2.7.0 has been released. I haven't reproduced it yet, so will leave the issue in "acknowledged" for now.

derick 2019-07-15 16:36 administrator ~0005061	I can't reproduce this - is this still causing you trouble?

theoboldt 2019-07-16 09:43 reporter ~0005063	Still reproducible using Xdebug 2.7.2, PHP FPM, having opcache enabled: Array ( [phpversion('xdebug')] => 2.7.2 [phpversion()] => 7.2.19-0ubuntu0.18.04.1 [php_sapi_name()] => fpm-fcgi ) Array ( [/var/www/localhost/xdebug.php] => Array ( [5] => 1 [6] => -1 [7] => 1 [8] => 1 [9] => -1 [10] => 1 [11] => 1 [12] => -1 [13] => 1 [14] => 1 [16] => 1 [17] => 1 [19] => 1 [24] => 1 [25] => 1 [26] => 1 [27] => 1 [29] => 1 ) ) Still reproducible using Xdebug 2.7.2, PHP FPM, having opcache disabled: Array ( [phpversion('xdebug')] => 2.7.2 [phpversion()] => 7.2.19-0ubuntu0.18.04.1 [php_sapi_name()] => fpm-fcgi ) Array ( [/var/www/localhost/xdebug.php] => Array ( [5] => 1 [6] => -1 [7] => 1 [8] => 1 [9] => -1 [10] => 1 [11] => 1 [12] => -1 [13] => 1 [14] => 1 [16] => 1 [17] => 1 [19] => 1 [20] => -2 [24] => 1 [25] => 1 [26] => 1 [27] => 1 [29] => 1 ) )

derick 2019-07-19 11:29 administrator ~0005071 Last edited: 2019-07-19 11:29	I just spend another two hours setting this up in a new and pristine VM with Ubuntu 18.04.2 LTS, which from what I can see is the exact same environment. The result is: Opcache disabled: Array ( [phpversion('xdebug')] => 2.7.2 [phpversion()] => 7.2.19-0ubuntu0.18.04.1 [php_sapi_name()] => fpm-fcgi ) Array ( [/var/www/html/test.php] => Array ( [5] => 1 [6] => 1 [7] => 1 [8] => 1 [9] => 1 [10] => 1 [11] => 1 [12] => 1 [13] => 1 [14] => 1 [16] => 1 [17] => 1 [19] => 1 [20] => -2 [24] => 1 [25] => 1 [26] => 1 [27] => 1 [29] => 1 ) ) Opcache enabled: Array ( [phpversion('xdebug')] => 2.7.2 [phpversion()] => 7.2.19-0ubuntu0.18.04.1 [php_sapi_name()] => fpm-fcgi ) Array ( [/var/www/html/test.php] => Array ( [5] => 1 [6] => 1 [7] => 1 [8] => 1 [9] => 1 [10] => 1 [11] => 1 [12] => 1 [13] => 1 [14] => 1 [16] => 1 [17] => 1 [19] => 1 [24] => 1 [25] => 1 [26] => 1 [27] => 1 [29] => 1 ) ) As you can see, I still can't reproduce this. I installed Xdebug from source and I also tried the php-xdebug package (Xdebug 2.6.0), and I still get the same result. There must be something different in your environment, although I can't see what would impact this. Is there any chance you can set-up a VM or something that shows the problem and you can give me access to?

theoboldt 2019-07-19 14:04 reporter ~0005079	We identified the configuration responsible for the error. If the configuration contains xdebug.coverage_enable = 0 , the error occurs. If the related configuration option is put in comments, no error occurs. If xdebug.coverage_enable = 1 is configured, no error occurs. I'd say that this should still be regarded as error, since it prevents users from collecting code coverage data of only specific snippets. We created a docker image which can be used to reproduce the error. When docker container is loaded and running, the container provides a web server at port 80. Proof can be found via /index.php . The bzip2 compressed docker image can be accessed within 7 days via: https://send.firefox.com/download/9b4b0fd39342cbca/#s7XDxm7K7sSWRmHY113vlQ

derick 2019-07-19 14:25 administrator ~0005080	Oh! If you turn off `xdebug.coverage_enable` then Xdebug should not do any code coverage whatsoever, so that is a bug. I can reproduce it when that configuration setting, so feel free to remove your Docker container.

derick 2019-07-27 22:39 administrator ~0005095	Fixed in 2.8.0beta2, by making sure there is a warning when you want to use code coverage when xdebug.code_coverage=0 (and duplicate of 0001540)

View Issue Details

Relationships

Activities