View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0000821 | Xdebug | Tracing | public | 2012-04-27 00:58 | 2020-03-12 17:34 |
Reporter | shdwjk | Assigned To | derick | ||
Priority | low | Severity | feature | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Platform | linux | OS | centos | ||
Product Version | 2.2.0RC2 | ||||
Target Version | 2.2.1 | Fixed in Version | 2.2.1 | ||
Summary | 0000821: Variable assignments (beginning with =>) should be indented one more scope | ||||
Description | Currently Variable assignments within a function have the same scope indentation as the function they are in. Example: -> SomeFunc() /some/file/path.php:1234
I believe these should be indented so that they show up inside the scope of the function: -> SomeFunc() /some/file/path.php:1234
| ||||
Steps To Reproduce | (in current behavior) | ||||
Tags | trace, xt file format | ||||
Operating System | linux | ||||
PHP Version | 5.3.10 | ||||
|
The "cheap" fix would be to change line 76 of xdebug_tracing.c from: That would fix the output, though it doesn't fix the fact the function_stack_entry->level is off by one. The level could just be considered one deeper for the purposes of this function, changing lines 73-75 of the same file from: Where xdebug_return_trace_assignment() is called in xdebug_code_coverage.c, the deepest stack frame is used for the first parameter. I'm not sure why this frame is not sufficiently deep. It may have something to do with the point at which variable definitions are determined from the Zend engine. Hope this additional info helps! |
|
Fixed for 2.2.1 and 2.3 on github. |
Date Modified | Username | Field | Change |
---|---|---|---|
2012-04-27 00:58 | shdwjk | New Issue | |
2012-04-27 23:53 | derick | Target Version | => 2.2.1 |
2012-06-14 14:36 | shdwjk | Note Added: 0002257 | |
2012-06-14 14:41 | shdwjk | Tag Attached: trace | |
2012-06-14 14:41 | shdwjk | Tag Attached: xt file format | |
2012-06-27 21:09 | derick | Note Added: 0002295 | |
2012-06-27 21:09 | derick | Status | new => closed |
2012-06-27 21:09 | derick | Assigned To | => derick |
2012-06-27 21:09 | derick | Resolution | open => fixed |
2012-06-27 21:09 | derick | Fixed in Version | => 2.2.1 |
2020-03-12 16:55 | derick | Severity | minor => feature |
2020-03-12 17:34 | derick | Category | Feature/Change request => Tracing |